clean up free-font-lock-settings #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- actually make highlighting operators work - bracket highlighing - remove features we don't currently have - remove broken interpolation
piotrkwiecinski
commented
May 22, 2023
| :language 'php | ||
| :feature 'operator | ||
| `([,@php-ts-mode--operators] @font-lock-operator-face) | ||
|
|
||
| :language 'php | ||
| :feature 'string |
There was a problem hiding this comment.
Note: this was a duplicate
piotrkwiecinski
commented
May 22, 2023
| (constant keyword string type variables) | ||
| (annotation expression literal function) | ||
| (bracket delimiter operator))) | ||
| (keyword string type variables) |
There was a problem hiding this comment.
We should think about value levels. I suggest we do it as a follow up when we stabilise types that we want to use. I put it in a checklist in #8
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I applied bright color for operators/brackets just for debugging.
Note: we'll have to work on nullable type and probably union type due to
?and|being marked as operators at the moment.